feat: 1927 flex geo json parsing failed #1947
Conversation
…rtedGeoJsonTypeNotice already covered the case.
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit ee877d8 📊 Notices ComparisonNew Errors (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1792 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 57af615 📊 Notices ComparisonNew Errors (3 out of 1801 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1801 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit e6e7f90 📊 Notices ComparisonNew Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1801 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 45216c4 📊 Notices ComparisonNew Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1801 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Summary:
Closes #1927
Expected behavior:
Added message fields to both MalformedJsonNotice and UnsupportedGeoJsonTypeNotice which already covered
geojson parsing failed.
Update 1/27: added a UnparsableGeoJsonFeatureNotice to cover all failed cases
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything